Size Change: +7 B (0%)

Total Size: 1.39 MB

_{compressed-size-action}

Flaky tests detected in a6f0c0e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5221992164
📝 Reported issues:

• [Flaky Test] Pick the additional variation in the inserted Columns block #47057 in specs/editor/plugins/block-variations.test.js
• [Flaky Test] should navigate using the list view sidebar #47001 in specs/editor/various/block-hierarchy-navigation.test.js

I would appreciate another quick code sanity check before you merge.

I feel we've been going back and forth on some of these things but I can't break this in any way so LGTM too.

Sorry to come back to this.

While testing background styles over in #59354 (comment), it became apparent that having a min-height on the html tag means that the site editor behaves differently to the frontend when setting background styles.

For example, the repeating background will still occur on the frontend despite the editor rule:

It's not such a big deal I guess, but it more apparent when the background is an image.

How closely do we want the site editor and frontend to match?

How closely do we want the site editor and frontend to match?

I think we want them to match as closely as possible. If this is considered a bug in the editor, it should be considered a bug in the frontend too.

I think we want them to match as closely as possible. If this is considered a bug in the editor, it should be considered a bug in the frontend too.

Thanks, there's a discussion over in #59354 (comment) about adding a min-height by default on :root for these types of backgrounds, so perhaps we can harmonize things that way.